fix(screensharing): picker performance and UI improvements #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
force-pushed
the
fix/screensharing-performance
branch
from
7239513 to
3b4a827
Compare
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/screensharing-performance
branch
from
3b4a827 to
fd588af
Compare
ShGKme
force-pushed
the
fix/screensharing-performance
branch
from
fd588af to
8281c85
Compare
ShGKme
force-pushed
the
fix/screensharing-performance
branch
from
8281c85 to
d75c5a2
Compare
Antreesy
approved these changes
Jan 31, 2025
ShGKme
force-pushed
the
fix/screensharing-performance
branch
from
d75c5a2 to
4566538
Compare
ShGKme
changed the title
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/screensharing-performance
branch
from
4566538 to
9659757
Compare
|
Applied suggestions from review. Replaces |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Performance issue 1: huge memory leak on quick cancel
If a user cancels screensharing before live previews are initialized, they won't be released in
onBeforUnmount. The stream is not ready yet inonBeforUnmount, so we cannot release it yet.Now checking that when stream is got, the video element to bind it to still exists and release otherwise.
How to test
mainbranchPerformance issue 2: sources list update is resource consuming
The list of sources is updated every second. It makes a short freeze every second. Then more sources are available - then more is the freeze and resource usage.
We may increase the interval to, e.g., 5 seconds.
But I'd consider an alternative - do it on visibility change. If a user goes from Talk Desktop to another window to open/close is and then goes back - it's refreshed.
The only case that is not covered here, if some window is closed on it's own. But the user just won't be able to share it in the end.
Performance issue 3: live preview is resource consuming
Live previews for many screens and windows may have a huge performance impact.
Making live preview optional.
Other changes
🖼️ Screenshots
🏚️ Before
🏡 After
Single source available
Only screens (no windows)
Wayland emulation
Video
screensharing.mp4